On Wed, 6 Sep 2023 21:35:49 GMT, Brent Christian <bchri...@openjdk.org> wrote:
>> Some benchmarks need the Class reference but some do not. For simplicity, >> use only walkers that retain Class reference so that all benchmarks can run >> with the default walker. > > In my mind, a "default" StackWalker (obtained from > no-arg`StackWalker.getInstance()`) does not retain the Class instance. I > think this will be confusing when the "default" Param value is reported in > JMH results. > > I like running the benchmarks with both sets of StackWalker options, but I > think the `default` Param value should be changed to something like, > `class+methods`. OK, can rename it. For the benchmarking purpose, it does not matter if it retains the Class instance or not. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15370#discussion_r1317907061
