On Mon, 4 Sep 2023 14:53:33 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Separate type cast from Shift bindings.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 425:
>
>> 423: if (type == int.class || isSubIntType(type)) {
>> 424: bindings.add(Binding.cast(type, long.class));
>> 425: type = long.class;
>
> This line seems redundant now (`type` is not used below).
Good catch! Removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15417#discussion_r1315066254
