On Thu, 24 Aug 2023 10:54:19 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> Recursive initialization calls possible during loading of LoggerFinder >> service. >> >> This fix detects the recursive call and returns a temporary LoggerFinder >> that is backed by a lazy logger. Automated test case developed to simulate >> loading of an external LoggerFinder service while also having other threads >> poke System.getLogger during this framework initialization. > > Sean Coffey has updated the pull request incrementally with two additional > commits since the last revision: > > - Improve test coverage > - Incorporate review comments from Daniel src/java.base/share/classes/jdk/internal/logger/BootstrapLogger.java line 988: > 986: private static void ensureClassInitialized(Class<?> c) { > 987: try { > 988: MethodHandles.lookup().ensureInitialized(c); Hello Sean, should we check if there are any implications, like on startup performance, of using `MethodHandles` in this `BootstrapLogger`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15404#discussion_r1305485295