On Tue, 22 Aug 2023 21:59:50 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

> - Added support for certificates with UNICODE characters.
> - Added new approach to find certificate using "security" and "openssl" 
> commands. Just "security" does not works, since it can truncate certificates 
> name. "security" is used to dump certificate in PEM format and then "openssl" 
> to get subject form PEM.
> - New approach works with UNICODE and ASCII, but I left old approach to avoid 
> regressions. If old approach fails to find certificate (UNICODE or very long 
> subject case) we will fallback to new approach.
> - Added tests for UNICODE to SigningAppImageTest and SigningPackageTest.java. 
> I do not think that we need to cover other signing cases for UNICODE.

Marked as reviewed by asemenyuk (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15394#pullrequestreview-1592110218

Reply via email to