On Tue, 22 Aug 2023 18:21:17 GMT, Weibing Xiao <d...@openjdk.org> wrote:
>> Please refer to JDK-8314063. >> >> The failure scenario is due to the setting of connection timeout. It is >> either too small or not an optimal value for the system. When the client >> tries to connect to the server with LDAPs protocol. It requires the >> handshake after the socket is created and connected, but it fails due to >> connection timeout and leaves the socket open. It is not closed properly due >> to the exception handling in the JDK code. >> >> The change is adding a try/catch block and closing the socket in the catch >> block, and the format of the code got changed consequently. > > Weibing Xiao has updated the pull request incrementally with one additional > commit since the last revision: > > format the code If the custom factory does not implement the method creatSocket (no method parameters), it will fail for creating the socket. The SocketFactory::createSocket is not defined as an abstract method, instead, it throws UnsupportedOperationException. The subclass is not required to implement it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15294#issuecomment-1689033617
