On Fri, 18 Aug 2023 03:57:24 GMT, Martin Stypinski <d...@openjdk.org> wrote:
> Added a bunch of different implementations for Vector API Matrix
> Multiplications:
>
> - Baseline
> - Blocked (Cache Local)
> - FMA
> - Vector API Simple Implementation
> - Vector API Blocked Implementation
>
> Commit was discussed with @PaulSandoz
test/micro/org/openjdk/bench/jdk/incubator/vector/MatrixMultiplicationBenchmark.java
line 33:
> 31:
> 32: import org.openjdk.jmh.annotations.*;
> 33: import org.openjdk.jmh.infra.Blackhole;
Unused import.
test/micro/org/openjdk/bench/jdk/incubator/vector/MatrixMultiplicationBenchmark.java
line 176:
> 174:
> 175: private static float[] newFloatRowMatrix(int size) {
> 176: Random rand = new Random();
Instead we can use the new random generator API e.g,:
var rand = RandomGenerator.getDefault();
This is not super important, but its good practice to try and use more
preferred APIs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15338#discussion_r1298830226
PR Review Comment: https://git.openjdk.org/jdk/pull/15338#discussion_r1298830156
