On Tue, 8 Aug 2023 09:59:39 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>>
>> Signed-off-by: Sidraya <sidraya.jayag...@ibm.com>
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 95:
>
>> 93:
>> 94: static const int native_invoker_code_base_size = 384;
>> 95: static const int native_invoker_size_per_args = 8;
>
> Sizes were taken from PPC64. Are they correct for s390?
Calculated code size and rounded off as per the s390x cache line size. Thank you
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 156:
>
>> 154: #endif
>> 155:
>> 156: int allocated_frame_size = 0;
>
> Line not needed.
Fixed. Thank you
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 163:
>
>> 161: assert(!_needs_return_buffer, "unexpected needs_return_buffer");
>> 162: RegSpiller out_reg_spiller(_output_registers);
>> 163: int spill_offset = -1;
>
> Line not needed.
Fixed. Thank you
> src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 130:
>
>> 128: }
>> 129: switch (to_reg.stack_size()) {
>> 130: case 8: __ reg2mem_opt(as_Register(from_reg), Address(Z_SP,
>> reg2offset(to_reg, out_bias)), true);break;
>
> Coding style: Spaces missing.
Fixed. Thank you
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 118:
>
>> 116:
>> 117: static const int upcall_stub_code_base_size = 1536; // depends on GC
>> (resolve_jobject)
>> 118: static const int upcall_stub_size_per_arg = 16; // arg save & restore +
>> move
>
> Again sizes from PPC64. Should be checked!
Calculated code size and rounded off as per the s390x cache line size. Thank you
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1297994858
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1297994949
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1297994309
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1297994258
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1297994768
