On Tue, 1 Aug 2023 06:29:28 GMT, sid8606 <d...@openjdk.org> wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Fix typo > > Signed-off-by: Sidraya <sidraya.jayag...@ibm.com>
src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger.java line 221: > 219: Class<?> type = > SharedUtils.primitiveCarrierForSize(layout.byteSize(), false); > 220: bindings.bufferLoad(0, type) > 221: .vmStore(storage, type); Maybe improve indentation? src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/TypeClass.java line 44: > 42: FLOAT; > 43: > 44: private static final int MAX_AGGREGATE_REGS_SIZE = 1; Unused. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1285885012 PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1285886685
