On Wed, 2 Aug 2023 23:25:13 GMT, Qing Xiao <d...@openjdk.org> wrote:

> Modified all tests under lib-test/jdk to use JUnit

test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java line 84:

> 82:                 Arguments.of("canonical", "%08x  ", "%02x ", 16, "|", 31, 
> HexPrinter.Formatters.PRINTABLE, "|" + System.lineSeparator()),
> 83:                 Arguments.of("simple", "%04x: ", "%02x ", 16, " // ", 64, 
> HexPrinter.Formatters.ASCII, System.lineSeparator()),
> 84:                 Arguments.of("source", "    ", "(byte)%3d, ", 8, " // ", 
> 64, HexPrinter.Formatters.PRINTABLE,  System.lineSeparator())

Suggestion:

                Arguments.of("source", "    ", "(byte)%3d, ", 8, " // ", 64, 
HexPrinter.Formatters.PRINTABLE, System.lineSeparator())

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15131#discussion_r1294433943

Reply via email to