On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >> while ago, we can now safely remove the compatibility workaround on Windows >> and have JLI_Snprintf simply delegate to snprintf. > > Julian Waters has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains seven additional > commits since the last revision: > > - Merge branch 'openjdk:master' into patch-1 > - Merge branch 'openjdk:master' into patch-1 > - Comment documenting change isn't required > - Merge branch 'openjdk:master' into patch-1 > - Comment formatting > - Remove Windows specific JLI_Snprintf implementation > - Remove Windows JLI_Snprintf definition That said C99 snprintf does not say anything about writing a NUL terminator in the case where nothing at all is written. ------------- PR Comment: https://git.openjdk.org/jdk/pull/10625#issuecomment-1651052351
