On Fri, 21 Jul 2023 10:55:13 GMT, Vladimir Petko <vpe...@openjdk.org> wrote:
> Use the same approach as Logger::defaultLogger() to ensure that the appender > is not destroyed before shared object destructor function is executed. > > The alternative is to delete dcon() function, but we might run into a > similiar tear-down issue later (e.g. logging from some object's destructor). > > > ============================== > Test summary > ============================== > TEST TOTAL PASS FAIL ERROR > > jtreg:test/jdk/tools 215 215 0 0 > > ============================== > TEST SUCCESS src/jdk.jpackage/share/native/common/app.cpp line 2: > 1: /* > 2: * Copyright (c) 2020, 2023 Oracle and/or its affiliates. All rights > reserved. Missing "," after 2023. Should be: "Copyright (c) 2020, 2023, Oracle and/or its affiliates.". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14971#discussion_r1271102509
