On Mon, 27 Mar 2023 23:34:52 GMT, Chen Liang <li...@openjdk.org> wrote:
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based > implementation of MethodHandleProxies.asInterface has a few issues: > 1. Exposes too much information via Proxy supertype (and WrapperInstance > interface) > 2. Does not allow future expansion to support SAM[^1] abstract classes > 3. Slow (in fact, very slow) > > This patch addresses all 3 problems: > 1. It updates the WrapperInstance methods to take an `Empty` to avoid method > clashes > 2. This patch obtains already generated classes from a ClassValue by the > requested interface type; the ClassValue can later be updated to compute > implementation generation for abstract classes as well. > 3. This patch's faster than old implementation in general. > > Benchmark for revision 17: > > Benchmark Mode Cnt > Score Error Units > MethodHandleProxiesAsIFInstance.baselineAllocCompute avgt 15 > 1.503 ± 0.021 ns/op > MethodHandleProxiesAsIFInstance.baselineCompute avgt 15 > 0.269 ± 0.005 ns/op > MethodHandleProxiesAsIFInstance.testCall avgt 15 > 1.806 ± 0.018 ns/op > MethodHandleProxiesAsIFInstance.testCreate avgt 15 > 17.332 ± 0.210 ns/op > MethodHandleProxiesAsIFInstance.testCreateCall avgt 15 > 19.296 ± 1.371 ns/op > MethodHandleProxiesAsIFInstanceCall.callDoable avgt 5 > 0.419 ± 0.004 ns/op > MethodHandleProxiesAsIFInstanceCall.callHandle avgt 5 > 0.421 ± 0.004 ns/op > MethodHandleProxiesAsIFInstanceCall.callInterfaceInstance avgt 5 > 1.731 ± 0.018 ns/op > MethodHandleProxiesAsIFInstanceCall.callLambda avgt 5 > 0.418 ± 0.003 ns/op > MethodHandleProxiesAsIFInstanceCall.constantDoable avgt 5 > 0.263 ± 0.003 ns/op > MethodHandleProxiesAsIFInstanceCall.constantHandle avgt 5 > 0.262 ± 0.002 ns/op > MethodHandleProxiesAsIFInstanceCall.constantInterfaceInstance avgt 5 > 0.262 ± 0.002 ns/op > MethodHandleProxiesAsIFInstanceCall.constantLambda avgt 5 > 0.267 ± 0.019 ns/op > MethodHandleProxiesAsIFInstanceCall.direct avgt 5 > 0.266 ± 0.013 ns/op > MethodHandleProxiesAsIFInstanceCreate.createCallInterfaceInstance avgt 5 > 18.057 ± 0.182 ns/op > MethodHandleProxiesAsIFInstanceCreate.createCallL... This pull request has now been integrated. Changeset: 5d57b5c2 Author: Chen Liang <li...@openjdk.org> Committer: Mandy Chung <mch...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/5d57b5c2f0ef77f994fbc8c4f09e66f217f06f85 Stats: 1451 lines in 13 files changed: 1050 ins; 311 del; 90 mod 6983726: Reimplement MethodHandleProxies.asInterfaceInstance Co-authored-by: Mandy Chung <mch...@openjdk.org> Reviewed-by: jvernee, mchung ------------- PR: https://git.openjdk.org/jdk/pull/13197
