On Fri, 14 Jul 2023 11:02:33 GMT, Jaikiran Pai <[email protected]> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback and bug id added to test
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 289:
>
>> 287: } else {
>> 288: ostream.println("Locale settings summary:");
>> 289: ostream.println(INDENT + "Use \":locale\" " +
>
> Hello Sean, should this instead say "Use "-XshowSettings:locale" ...." so
> that it's clear that this is a sub-option for the -XshowSettings option?
Yes, no harm to be clearer Jai. Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14885#discussion_r1263614727
