On Sat, 8 Jul 2023 02:05:27 GMT, Jenny Shivayogi <d...@openjdk.org> wrote:
> Free-ing 'buf' before two conditional return statements introduced by
> JDK-8307990
Looks okay, but need to fix two whitespace errors for jcheck to be happy.
Also, attention @simonis, whose patch introduced this little problem, I think.
src/java.base/unix/native/libjava/ProcessImpl_md.c line 566:
> 564: if (writeFully(c->childenv[1], (char *)&magic, sizeof(magic)) !=
> sizeof(magic)) { // magic number first
> 565: free(buf);
> 566: return -1;
See jcheck warnings: there is `TAB` on this line, which should be replaced by
4-space indents.
src/java.base/unix/native/libjava/ProcessImpl_md.c line 575:
> 573: writeFully(c->childenv[1], buf, bufsize) != bufsize) {
> 574: free(buf);
> 575: return -1;
Same here.
-------------
Changes requested by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14809#pullrequestreview-1521836916
PR Review Comment: https://git.openjdk.org/jdk/pull/14809#discussion_r1258092041
PR Review Comment: https://git.openjdk.org/jdk/pull/14809#discussion_r1258092196
