On Fri, 30 Jun 2023 16:49:22 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which refactors Currency tests to use JUnit. >> >> The most significant change occurs in `ValidateISO4217.java`. Other changes >> to this file excluding the JUnit refactoring include >> >> - Tests are no longer dependent on each other (order of execution does not >> matter) >> - Testing does not occur at the same time as data generation (The data is >> fully generated before any tests are executed) >> - Various cleanup (dead-code, clarifying comments, more descriptive method >> and var names) >> >> `Bug4512215.java` now renamed to `MinorUndefinedCodes` was updated to remove >> redundant testing, and the file changed to focus on testing minor undefined >> currency codes instead. > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Review: Adjust data provider regarding Turkish Lira LGTM. Thanks for the refactoring ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14682#pullrequestreview-1507553074
