> Please review this PR which refactors Currency tests to use JUnit.
> 
> The most significant change occurs in `ValidateISO4217.java`. Other changes 
> to this file excluding the JUnit refactoring include
> 
> - Tests are no longer dependent on each other (order of execution does not 
> matter)
> - Testing does not occur at the same time as data generation (The data is 
> fully generated before any tests are executed)
> - Various cleanup (dead-code, clarifying comments, more descriptive method 
> and var names)
> 
> `Bug4512215.java` now renamed to `MinorUndefinedCodes` was updated to remove 
> redundant testing, and the file changed to focus on testing minor undefined 
> currency codes instead.

Justin Lu has updated the pull request incrementally with one additional commit 
since the last revision:

  Review: Adjust data provider regarding Turkish Lira

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14682/files
  - new: https://git.openjdk.org/jdk/pull/14682/files/ba3d2e5d..0ada95ed

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14682&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14682&range=04-05

  Stats: 4 lines in 1 file changed: 2 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14682.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14682/head:pull/14682

PR: https://git.openjdk.org/jdk/pull/14682

Reply via email to