On Tue, 27 Jun 2023 19:07:12 GMT, Jim Laskey <jlas...@openjdk.org> wrote:
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent > caching scheme for Carrier objects. The technique used is generally useful > for a variety of caching schemes and is being moved to be shared in other > parts of the jdk. The MethodType interning case is one example. Looks fine to me. Good to see this class is being shared, as this can be used for refactoring the locale-related caches (https://github.com/openjdk/jdk/pull/14404). src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 84: > 82: * Warning: This class is part of PreviewFeature.Feature.STRING_TEMPLATES. > 83: * Do not rely on its availability. > 84: */ Now that this is shared by other components, do we still need this warning? ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14684#pullrequestreview-1505739194 PR Review Comment: https://git.openjdk.org/jdk/pull/14684#discussion_r1246903833
