On Tue, 27 Jun 2023 16:35:20 GMT, Alan Bateman <al...@openjdk.org> wrote:

> > Wenshao hopes to use this array for other optimizations in `java.lang` in 
> > the future.
> > But as for this PR, I suggest wenshao not to do so much. I suggest moving 
> > `DIGITS` back to `HexDigits` first to make the modifications in this PR 
> > smaller. Reducing modifications helps with faster review.
> > When you need to optimize the classes in `java.lang`, we will continue to 
> > discuss how to share these arrays more safely and efficiently.
> 
> Let's keep this PR as simple as possible. Right now, it's up to 100 comments 
> and 27 iterations, it's annoying to be sending new contributor Wenshao in 
> different directions. Future work that would allow safer sharing of arrays is 
> future work, let's keep this PR as simple as possible. Not all applications 
> use UUID.

good suggestion, it has been changed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14578#issuecomment-1609938471

Reply via email to