> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launched, the code would assume the byte order in the image to be the native > order of the host where the image is being launched. That would result in > failure to launch java, as noted in the linked issue. > > The commit in this PR, changes relevant places to not assume native order and > instead determine the byte order by reading the magic bytes in the image > file's header content. > > A new jtreg test has been added which reproduces the issue and verifies the > fix.
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits: - update jdk.tools.jlink.internal.Platform class to be aware of non-current platform's endianness - remove no longer needed constructor - merge latest from master branch - foo - merge latest from master branch - cleanup test - rename method and update code comment as suggested by Alan - Rename KNOWN_ENDIANNESS to PLATFORM_PROPERTIES - use test.jdk system property in test - don't iterate over the properties file keys and instead do lookup when needed - update CDSPluginTest to correctly "simulate" cross-platform test - ... and 30 more: https://git.openjdk.org/jdk/compare/013367b4...532ea3f6 ------------- Changes: https://git.openjdk.org/jdk/pull/11943/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11943&range=17 Stats: 220 lines in 10 files changed: 175 ins; 14 del; 31 mod Patch: https://git.openjdk.org/jdk/pull/11943.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/11943/head:pull/11943 PR: https://git.openjdk.org/jdk/pull/11943
