On Sat, 24 Jun 2023 06:11:55 GMT, Glavo <d...@openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/util/ByteArrayLittleEndian.java
>> line 150:
>>
>>> 148: public static long getUnsignedInt(byte[] array, int offset) {
>>> 149: return Integer.toUnsignedLong((int) INT.get(array, offset));
>>> 150: }
>>
>> Hello Glavo, I was going to recommend adding a test method to existing jtreg
>> tests to test these new methods. But it looks like there's no jtreg test for
>> this `ByteArrayLittleEndian` class. Would you mind creating a new test class
>> to (at least) test these methods?
>
>> Hello Glavo, I was going to recommend adding a test method to existing jtreg
>> tests to test these new methods. But it looks like there's no jtreg test for
>> this `ByteArrayLittleEndian` class. Would you mind creating a new test class
>> to (at least) test these methods?
>
> I think I could modify
> `test/jdk/jdk/internal/util/ByteArray/ReadWriteValues.java` to also test
> `ByteArrayLittleEndian`.
I added a test for `ByteArrayLittleEndian` in #14636
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14632#discussion_r1240723205
