On Fri, 16 Jun 2023 15:06:30 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Left some comments on the translations mainly in Japanese. It is now very >> easy to look at the l10n changes in the generated HTML. One small comment to >> the tool is that it would be nice if the order in HTML (alphabetically >> sorted currently) aligns with the order in the actual resource file. It is a >> great improvement anyways. > >> Left some comments on the translations mainly in Japanese. It is now very >> easy to look at the l10n changes in the generated HTML. One small comment to >> the tool is that it would be nice if the order in HTML (alphabetically >> sorted currently) aligns with the order in the actual resource file. It is a >> great improvement anyways. > > 1. It is not easy to recover the order in the actual resource file: the > contents are read into a `Properties` object which uses a `Hashtable` to > store the data. > 2. There is no guarantee that the order is the same in all the resource > files, so we would have to choose one, presumably the default one, to > determine the presentation order. > 3. The iteration order would be undefined when resources are removed from one > or more resource files Makes sense. Thanks for the explanation @jonathan-gibbons ------------- PR Comment: https://git.openjdk.org/jdk/pull/14430#issuecomment-1594999086
