On Tue, 13 Jun 2023 13:09:49 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing comments (test grouping, synchronization), minor optimization >> on loop lookup > > test/micro/org/openjdk/bench/java/util/LocaleCache.java line 58: > >> 56: throw new RuntimeException("Different Locale was >> created"); >> 57: } >> 58: previous = l; > > Suggestion: > > previous = l; Fixed > test/micro/org/openjdk/bench/java/util/LocaleCache.java line 70: > >> 68: throw new RuntimeException("Different Locale was >> created"); >> 69: } >> 70: previous = l; > > Suggestion: > > previous = l; Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14404#discussion_r1228504659 PR Review Comment: https://git.openjdk.org/jdk/pull/14404#discussion_r1228504936