On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
Will this method be tested by the changes in pull/13689?
src/java.base/share/classes/java/lang/Class.java line 29:
> 27:
> 28: import jdk.internal.javac.PreviewFeature;
> 29: import jdk.internal.misc.PreviewFeatures;
Can you move this so that it's with the other imports of jdk.internal classes?
src/java.base/share/classes/java/lang/Class.java line 194:
> 192: * <h2><a id=unnamedClasses>Unnamed Classes</a></h2>
> 193: *
> 194: * A {@code class} file representing an {@linkplain #isUnnamedClass
> unnamed class} is generated by
Are you going to reflow this paragraph before you are done, only wondering as
there is one line sticking out compared the rest of the paragraph.
src/java.base/share/classes/java/lang/Class.java line 216:
> 214: * {@linkplain #getSimpleName
> 215: * simple name} of such an unnamed class is the empty string and the
> 216: * {@linkplain #getCanonicalName canonical name} is {@code null}.
This sentence is quite long. You might to consider splitting it up, or at
minimally put a comma after "empty string" to allow the reader draw breath.
src/java.base/share/classes/java/lang/Class.java line 1881:
> 1879: * @since 21
> 1880: */
> 1881: @PreviewFeature(feature=PreviewFeature.Feature.UNNAMED_CLASSES,
Is there a JLS section to reference?
-------------
PR Review: https://git.openjdk.org/jdk/pull/14165#pullrequestreview-1462196037
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1217845247
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1217846409
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1217854569
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1217848157
