On Thu, 1 Jun 2023 19:24:35 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix wrong link in layout well-formedness doc
>
> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 645:
>
>> 643: * is 1. As such, regardless of its size, in the absence of an
>> {@linkplain #withByteAlignment(long) explicit}
>> 644: * alignment constraint, a padding layout does not affect the
>> alignment constraint of the group or sequence layout
>> 645: * it is nested into.
>
> It is possible to override the alignment constraints of group and sequence
> layouts, so maybe this should say _natural alignment_.
> Suggestion:
>
> * alignment constraint, a padding layout does not affect the natural
> alignment of the group or sequence layout
> * it is nested into.
On a related note: should we even allow sequences of padding layouts?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14098#discussion_r1213585708
