On Thu, 1 Jun 2023 15:14:52 GMT, Chen Liang <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed benchmarks
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java
> line 840:
>
>> 838: try {
>> 839: //clone SplitConstantPool with alternate context
>> 840: var cc =
>> Classfile.of(Classfile.StackMapsOption.DO_NOT_GENERATE_STACK_MAPS);
>
> This should set the Class hierarchy resolver, patch dead code, and filter
> dead labels options from the original context.
Here the other options are irrelevant. The error report wraps already generated
incomplete code attribute into a fake class to be able to print details to the
error.
I think even the stack map generation suppression is irrelevant here, will
double check.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14180#discussion_r1213598996
