On Thu, 1 Jun 2023 12:01:15 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

>  It's easy to introduce a new change to this code which accidentally drags in 
> some of those (unwanted) dependencies again.

I do not like the changes proposed here, they are all crying out for several 
round cleanups and modernization. One thing that would help is to split this up 
into a series of changes that could be evaluated, e.g. the use of regex may be 
a significant part of this so maybe start with that, report back, then work 
through the iterations to make it clean and maintainable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14216#issuecomment-1571939629

Reply via email to