On Tue, 30 May 2023 22:20:23 GMT, David Holmes <dhol...@openjdk.org> wrote:
> What testing was done on this fix before integration? I don't even see Git > Hub Actions being run. @dholmes-ora I did see earlier that Github Action ran (In the 'Checks' tab) and finished, and I believed the Windows failure is not related to my patch. Perhaps GHA does not cover the jmh build. I ran the full jtreg tests in our internal ci with my first draft patch, but I realized that I forgot to have another run of full jtreg test after updating my patch to the current version. I only ran my new jtreg test before integration. Lesson learnt! Thanks @DamonFool for the quick fix. I am working on JDK-8309129. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13974#issuecomment-1569424140
