On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE) >> is gcc or clang, as suggested by @erikj79. > > I ran this patch in our internal build and test system and got failures on > macos and windows. I think I know the cause for the mac failure, but the > Windows failure I don't know. It looks like the same error I saw before after > the original patch went in. > > > [2023-05-19T20:51:31,466Z] > c:\sb\prod\1684529071\workspace\open\src\hotspot\share\compiler\disassembler.cpp(792): > error C2220: the following warning is treated as an error > [2023-05-19T20:51:31,466Z] > c:\sb\prod\1684529071\workspace\open\src\hotspot\share\compiler\disassembler.cpp(792): > warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data > [2023-05-19T20:51:31,466Z] lib/CompileJvm.gmk:152: recipe for target > '/cygdrive/c/sb/prod/1684529071/workspace/build/windows-x64-open/hotspot/variant-server/libjvm/objs/static/disassembler.obj' > failed > [2023-05-19T20:51:31,466Z] make[3]: *** > [/cygdrive/c/sb/prod/1684529071/workspace/build/windows-x64-open/hotspot/variant-server/libjvm/objs/static/disassembler.obj] > Error 1 Hi @erikj79 Please let me know if you have any additional comments for the PR. Could you please also help run through testing for the latest version? Thanks ------------- PR Comment: https://git.openjdk.org/jdk/pull/14064#issuecomment-1561320098
