On Tue, 23 May 2023 07:55:35 GMT, Christian Hagedorn <chaged...@openjdk.org>
wrote:
>> Tobias Holenstein has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update Test8211698.java
>> - Update src/hotspot/share/compiler/compilerOracle.cpp
>>
>> Co-authored-by: Christian Hagedorn <christian.haged...@oracle.com>
>> - Update src/hotspot/share/compiler/compilerOracle.cpp
>>
>> Co-authored-by: Christian Hagedorn <christian.haged...@oracle.com>
>
> src/hotspot/share/compiler/compilerOracle.cpp line 1017:
>
>> 1015: if (line[0] == '\0') return;
>> 1016: ResourceMark rm;
>> 1017: char error_buf[1024] = {0};
>
> Wouldn't it be sufficient to only initialize the first character with `\0`?
Probably, but all other error buffer also init with zero. I will leave it for
now. Can update them all together in the future
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13802#discussion_r1203930148
