On Tue, 2 May 2023 11:35:54 GMT, Tobias Holenstein <tholenst...@openjdk.org> wrote:
> Currently, errors during compile command parsing just print an error but > don't exit the VM. As a result, issues go unnoticed. > > With this PR the behavior is changed to exit the VM when an error occurs. > > E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the > VM after a parsing occurred. > > CompileCommand: An error occurred during parsing > Error: Could not parse method pattern > Line: 'compileonly,HashMap::' > > Usage: '-XX:CompileCommand=<option>,<method pattern>' - to set boolean option > to true > Usage: '-XX:CompileCommand=<option>,<method pattern>,<value>' > Use: '-XX:CompileCommand=help' for more information and to list all option. > > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > ### Updated Tests > Updated all tests to now expect an error code `1` for wrong `CompileCommand` Looks good. ------------- Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13753#pullrequestreview-1440125001
