On Tue, 23 May 2023 15:31:49 GMT, Michael McMahon <micha...@openjdk.org> wrote:

>> This PR creates a new version of the JNI utility function 
>> JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which 
>> performs additional validation of the returned string, namely that it does 
>> not contain any embedded NULL characters. If any such characters are found 
>> the function returns NULL with an IAE pending. The change also switches 
>> usage in the networking native code to use the new function.
>> 
>> This cautious approach was taken rather than changing the behavior of the 
>> existing function as each native code area needs to review the effect of 
>> making the switch. Otherwise, surprising behavior changes might occur (eg 
>> undocumented IAE being thrown to user code instead of some other exception).
>
> Michael McMahon has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   test comment update

Looks good

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14083#pullrequestreview-1440123393

Reply via email to