On Fri, 19 May 2023 21:13:37 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This change intends to interpret the BCP47 U extension wrt collation >> settings in the given `Locale`, then applies them to the created instances >> in the 1-arg factory method in `Collator`. A corresponding CSR has also been >> drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > A bit of clarification I went through the latest javadoc but the last sentence is still confusing. I think the part that is missing is the method doesn't make it clear up front that it gets requested locale and then attempts to set its strength and decomposition if recognized. If this were clear in the first part of the method description then it is okay to say that the returned Collator might not have the expected strength and decomposition. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14040#issuecomment-1556131544
