On Tue, 16 May 2023 10:38:52 GMT, Darragh Clarke <d...@openjdk.org> wrote:
> Updated instances of `toLowerCase` and `toUpperCase` in several net and io
> files to specify `Locale.ROOT` to ensure that case conversion issues don't
> occur,
>
> I didn't add any new tests but ran tier 1-3 with no issues
src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java
line 516:
> 514:
> 515: if (nccount != -1) {
> 516: ncstring = Integer.toHexString
> (nccount).toLowerCase(Locale.ROOT);
Suggestion:
ncstring = Integer.toHexString(nccount);
`toHexString` returns lowercase string
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14006#discussion_r1196296029
