On Tue, 9 May 2023 15:57:44 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> test/micro/org/openjdk/bench/jdk/classfile/RebuildMethodBodies.java line 42:
>>
>>> 40: @BenchmarkMode(Mode.Throughput)
>>> 41: @State(Scope.Benchmark)
>>> 42: @Fork(value = 1, jvmArgsAppend = {"--enable-preview"})
>>
>> Suggestion:
>>
>> @Fork(value = 1, jvmArgsAppend = {"--enable-preview",
>> "--add-opens",
>> "java.base/jdk.internal.classfile=ALL-UNNAMED",
>> "--add-opens",
>> "java.base/jdk.internal.classfile.constantpool=ALL-UNNAMED",
>> "--add-opens",
>> "java.base/jdk.internal.classfile.instruction=ALL-UNNAMED"})
>
> To make this runnable without manually adding a bunch of `--add-opens` flags
They are added in the `make/RunTests.gmk`:
https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f059233R599-R608
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13671#discussion_r1188832580
