On Mon, 24 Apr 2023 12:18:55 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Add `split()` overloads to `String` and `java.util.regex.Pattern` that, in >> addition to the substrings returned by current `split()` variants, also >> return the delimiters matching the regular expression. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Small optimization in private split(). > Added tests to compare String and Pattern implementations, in particular > for one char regex. Overall, the changes look OK to me. I have a comment about the javadoc which I've added inline. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13305#issuecomment-1538250225
