On Thu, 27 Apr 2023 17:21:23 GMT, Jim Laskey <jlas...@openjdk.org> wrote:

>> Enhance the Java programming language with string templates, which are 
>> similar to string literals but contain embedded expressions. A string 
>> template is interpreted at run time by replacing each expression with the 
>> result of evaluating that expression, possibly after further validation and 
>> transformation. This is a [preview language feature and 
>> API](http://openjdk.java.net/jeps/12).
>
> Jim Laskey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   CSR recommendations

src/java.base/share/classes/java/lang/StringTemplate.java line 427:

> 425:      * {@link StringTemplate}. To accommodate concatenation, values are 
> converted to strings
> 426:      * as if invoking {@link String#valueOf(Object)}.
> 427:      * @implNote {@link StringTemplate#STR} is statically imported 
> implicitly into every

IMO the remark regarding  STR being auto-imported works better as an apiNote 
rather than an implNote.

Regarding interning, I think an implSpec of "may or may not be interned" 
provides maximum flexibility to the implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1186601013

Reply via email to