On Wed, 26 Apr 2023 20:08:51 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Move getErrorCount() back to original spot >> - Regardles of nothrow, final result should be logged, cache, move method >> back > > Looks good overall perhaps consider using `HexFormat` instead of the private > method `toHexString` @LanceAndersen Thanks for the review. Changed it so that `HexFormat` methods are used, luckily only one subclass used `toHexString`. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13655#issuecomment-1524179840
