On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar <amitku...@openjdk.org> wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be recovered after compression. This PR updates the check method in >> the DeInflate test to no longer rely on pre-defined lengths/sizes to >> determine whether deflate followed by an inflate of data worked correctly. >> These sizes can vary depending on the underlying zlib implementations. The >> updated check method now uses a `ByteArrayOutputStream` to deflate into and >> then inflate from. >> >> Thanks to @jaikiran for amazing PR description. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > removes out1,out2 parameters The changes look OK. I think this would be a good opportunity to add some comments to this test especially to the check method Jai, have you run this acrossed all of our Mach5 platforms? test/jdk/java/util/zip/DeInflate.java line 129: > 127: int m = 0; > 128: > 129: ByteArrayOutputStream baos = new ByteArrayOutputStream(len); Is there a reason a try-with-resources is not being used? ------------- PR Review: https://git.openjdk.org/jdk/pull/12283#pullrequestreview-1402766747 PR Review Comment: https://git.openjdk.org/jdk/pull/12283#discussion_r1178363485
