On Thu, 30 Mar 2023 03:06:51 GMT, Amit Kumar <amitku...@openjdk.org> wrote:
>> DeInflate.java test fails on s390x platform because size for out1 array >> which is responsible for storing the compressed data is insufficient. And >> being unable to write whole compressed data on array, on s390 whole data >> can't be recovered after compression. So this fix increase Array size (for >> s390). > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > removes out1,out2 parameters Marked as reviewed by jpai (Reviewer). Hello Amit, I had a look at the latest state of this PR, commit `bce8989275`. What this change does is that it updates the `check` method in the `DeInflate` test to no longer rely on pre-defined lengths/sizes to determine whether deflate followed by an inflate of data worked correctly. These sizes can vary depending on the underlying `zlib` implementations. The updated `check` method now uses a `ByteArrayOutputStream` to deflate into and then inflate from. The final inflated data is then compared against the original input and asserted that it's the same (this part hasn't changed in this PR). These changes look fine to me. ------------- PR Review: https://git.openjdk.org/jdk/pull/12283#pullrequestreview-1401722800 PR Comment: https://git.openjdk.org/jdk/pull/12283#issuecomment-1523218435
