On Tue, 18 Apr 2023 21:04:05 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Peter Hofer has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8305746: InitializeEncoding should cache Charset object instead of charset >> name > > src/java.base/share/native/libjava/jni_util.c line 757: > >> 755: jnuEncoding = (*env)->NewGlobalRef(env, charset.l); >> 756: (*env)->DeleteLocalRef(env, charset.l); >> 757: break; > > Could return immediately No, then the method id cache would not get initialized below. But I will add a comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13499#discussion_r1170880852
