On Tue, 11 Apr 2023 20:50:28 GMT, Mark Sheppard <mshep...@openjdk.org> wrote:
>> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > test/jdk/TEST.groups line 643: > >> 641: sun/security/tools/jarsigner/compatibility/Compatibility.java >> 642: >> 643: jdk_core_manual_human = \ > > jdk_core_manual_requires_human_input gave a good indication of what is needed > with this test group ... maybe jdk_core_manual_interactive if we don't want > to use requires_human_input The name "jdk_core_manual_requires_human_input" may not be suitable because some tests in this group require environment preparation or root privilege. I prefer the name "jdk_core_manual_interactive". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12840#discussion_r1163371467
