On Mon, 20 Mar 2023 23:29:25 GMT, Bill Huang <bhu...@openjdk.org> wrote:
>> The purpose of this task is to add the difference between -manual jdk_core >> and jdk_core_manual to the jdk_core_manual test goal. Furthermore, in order >> to streamline the manual test execution process, a new test group called >> jdk_core_manual_human has been created for manual tests that demand extra >> preparation or test input. > > Bill Huang has updated the pull request incrementally with one additional > commit since the last revision: > > Implemented review comments. test/jdk/TEST.groups line 600: > 598: > 599: jdk_core_manual = \ > 600: :jdk_core_manual_no_input \ jdk_core_manual_human (as it is now called) should be part of jdk_core_manual, as jdk_core_manual will be used in the corelibs-atr job test/jdk/TEST.groups line 643: > 641: sun/security/tools/jarsigner/compatibility/Compatibility.java > 642: > 643: jdk_core_manual_human = \ jdk_core_manual_requires_human_input gave a good indication of what is needed with this test group ... maybe jdk_core_manual_interactive if we don't want to use requires_human_input ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12840#discussion_r1163314338 PR Review Comment: https://git.openjdk.org/jdk/pull/12840#discussion_r1163316682