On Tue, 11 Apr 2023 18:02:14 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modified test to check Architecture is64bits() and isLittleEndian()
>> against Unsafe respective values.
>> Relocated code mapping OS name and arch name from PlatformProps to
>> OperatingSystem and Architecture. Kept the mapping of names
>> in the template close to where the values are filled in by the build.
>
> test/jdk/jdk/internal/util/ArchTest.java line 74:
>
>> 72: case "riscv64" -> RISCV64; // unverified
>> 73: case "s390x", "s390" -> S390; // unverified
>> 74: case "ppc64le" -> PPC64; // unverified
>
> I think "ppc64" should also get mapped to "PPC64".
Suggestion:
case "ppc64", "ppc64le" -> PPC64; // unverified
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1163166827
