On Sun, 19 Mar 2023 14:50:41 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:

>> ZipOutputStream currently writes directory entries using the DEFLATED 
>> compression method. This does not strictly comply with the APPNOTE.TXT 
>> specification and is also about 10x slower than using the STORED compression 
>> method.
>> 
>> Because of these concerns, `ZipOutputStream.putNextEntry` should be updated 
>> with an `@apiNote` recommending
>> the use of the STORED compression method for directory entries.
>> 
>> Suggested CSR in the first comment.
>
> Eirik Bjorsnos has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove speculation that using DEFLATED for directory entries is not in 
> strict compliance with APPNOTE.txt

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/12899#pullrequestreview-1375448942

Reply via email to