On Fri, 31 Mar 2023 18:24:26 GMT, Martin Buchholz <mar...@openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with four >> additional commits since the last revision: >> >> - Document the structure of the 'good' ZIP >> - Use the "Validate that.." comment style >> - Document the ByteBuffer with a comment >> - Use ByteBuffer when manipulating multi-byte fields > > test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java line 246: > >> 244: /* >> 245: * Validate that a ZipException is thrown if the last CEN header is >> 246: * not immediatly followed by the start of the 'End of central >> directory' record > > typo: immediatly Thanks, fixed. > test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java line 300: > >> 298: >> 299: /* >> 300: * Validate that a ZipException is thrown when a LOC header has an >> unexpected signature > > I would leave off "Validate that" Thanks, updated all test comments to strip this shared prefix. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/12563#discussion_r1154844736 PR Review Comment: https://git.openjdk.org/jdk/pull/12563#discussion_r1154844995
