On Sat, 25 Mar 2023 03:54:23 GMT, Stuart Marks <sma...@openjdk.org> wrote:
>> PR for Sequenced Collections implementation.
>
> Stuart Marks has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - More specification tweaks.
> - Add simple overrides to ArrayList.
src/java.base/share/classes/java/util/Collections.java line 1184:
> 1182:
> 1183: @SuppressWarnings("unchecked")
> 1184: private SequencedCollection<E> rc() {
I suggest to use 'delegate' as name instead of 'rc' (no idea what 'rc' means)
src/java.base/share/classes/java/util/Collections.java line 6014:
> 6012: */
> 6013: public static <E> SequencedSet<E>
> newSequencedSetFromMap(SequencedMap<E, Boolean> map) {
> 6014: if (! map.isEmpty())
This line does an implicit NPE check, either make it explicit using
requireNonNull or at least add a comment
src/java.base/share/classes/java/util/Collections.java line 6023:
> 6021: */
> 6022: private static class SequencedSetFromMap<E> extends SetFromMap<E>
> implements SequencedSet<E> {
> 6023: private final E nsee(Map.Entry<E, Boolean> e) {
`static` instead of `final`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1148320373
PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1148320720
PR Review Comment: https://git.openjdk.org/jdk/pull/7387#discussion_r1148320942
