On Thu, 23 Mar 2023 12:32:58 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
>>> @AlanBateman @pavelrappo Does the new approach seem acceptable? >> >> I don't have a strong opinion on this. The advantage is that the test is >> probably sub-second as it just needs one CF to complete exceptionally. The >> disadvantage is that it the test would need to be updated if the >> implementation changes, but it's not hard. >> >> So good with the approach if you want. As Jai mentioned, you can use >> @modules to open java.base/java.util.concurrent for deep reflectively. I >> would probably trim the overly long lines as they currently wrap when >> looking at the diffs. > > While the approach seems okay, it might be for the JSR 166 folk to make the > final decision on it. > > (Looking at Thread.sleep(). Sigh: unfortunately, BlockingQueue does not > provide an option to examine its head that blocks or times out.) @pavelrappo `peek(timeout, unit)` would be nice :) @AlanBateman Sounds good, I'll change to use @modules 👍 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13116#discussion_r1146160066
