On Wed, 22 Mar 2023 18:04:15 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve javadocs for Linker::captureStateLayout
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 2315:
>
>> 2313: * @return {@code true}, if the provided object is also a
>> scope, which models the same lifetime as that
>> 2314: * modelled by this scope.
>> 2315: */
>
> A `@return` tag could be used here
> Suggestion:
>
> /**
> * {@return {@code true}, if the provided object is also a scope,
> which models the same lifetime as that
> * modelled by this scope.} In that case, it is always the case that
> * {@code this.isAlive() == ((Scope)that).isAlive()}.
> * @param that the object to be tested.
> */
Oh - I didn't know you could use return tag plus other text...
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1145284853
