On Mon, 13 Mar 2023 23:20:35 GMT, Mandy Chung <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> don't hardcode the .jmod extension while determining java.base module
>> location
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 834:
>
>> 832: // find the target platform's arch and thus its
>> endianness from the java.base
>> 833: // module's ModuleTarget attribute
>> 834: Optional<ResolvedModule> javaBase =
>> cf.findModule("java.base");
>
> `ModuleTarget` is read by `DefaultImageReader::storeFiles` as well. Perhaps
> it should be refactored so that the target `Platform` can be passed to
> `DefaultImageBuilder`.
I've updated the PR to pass along this already parsed target platform to the
`DefaultImageBuilder`. This code is new to me and I think I made sure (by
checking references and the package names) that I only updated the internal
classes without impacting any user facing APIs. If however, this impacts any
user facing API, please do let me know.
-------------
PR: https://git.openjdk.org/jdk/pull/11943
