On Thu, 16 Mar 2023 18:12:23 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Switch to DataProvider
>
> test/jdk/java/lang/constant/ConstantDescsTest.java line 65:
>
>> 63: */
>> 64: @Test
>> 65: public void validateAllFields() throws ReflectiveOperationException {
>
> It might be nice to use a `@DataProvider` to feed in the different
> ConstantDescs and expected resolved values. Saves on some of the duplication.
Done. Replaced `assertSame` with `assertEquals` as future constant descs may
resolve to equals-based than identity-based constants.
-------------
PR: https://git.openjdk.org/jdk/pull/13064
